fix:disable save button when the project is playing (#4239)#4241
Closed
BeNikk wants to merge 2 commits intosugarlabs:masterfrom
Closed
fix:disable save button when the project is playing (#4239)#4241BeNikk wants to merge 2 commits intosugarlabs:masterfrom
BeNikk wants to merge 2 commits intosugarlabs:masterfrom
Conversation
Contributor
Author
|
@pikurasa @walterbender I think disabling buttons during play can be achieved like this as discussed in #4239 |
Member
|
The save project button was not disabled (at least for me on FireFox/Fedora). How did you test? |
Contributor
Author
|
it looks like the buttons are getting re-enabled after 2 seconds because of a setTImeout function that debounces the play button, i will have a look, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue (#4239) by disabling the save and record buttons while a project is playing to prevent buggy behavior.
Changes made
Screenshot
Screencast.from.08-01-25.02.33.14.AM.IST.webm